Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add dependabot for test and hack/tools module #9041

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

killianmuldoon
Copy link
Contributor

Enable dependabot for the hack/tools and test go modules.

Dependabot needs to be pointed to each directory holding a go module seperately. Previously we got updates to some dependencies in these files due to our dependeabot go generation job which runs go mod tidy on all modules.
Fixes #

@killianmuldoon
Copy link
Contributor Author

/area ci

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/ci Issues or PRs related to ci size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2023
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this on my own branch. You can see on the Insights tab for the repo (not sure who can see it or how much), under Dependencies and Dependabot which files the CI is looking at when it's looking to do upgrades.

Signed-off-by: killianmuldoon <[email protected]>
@sbueringer
Copy link
Member

Thank you very much!!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac13715b434876934311704dd3f3b83fa89ada66

@sbueringer
Copy link
Member

/retitle 🌱 Add dependabot for test and hack/tools module

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Add dependabot for test module 🌱 Add dependabot for test and hack/tools module Jul 21, 2023
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "weekly"
day: "monday"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fridays? 🙃

Copy link
Member

@sbueringer sbueringer Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can collect PRs during the week and then merge on Friday :)

@k8s-ci-robot k8s-ci-robot merged commit 272ddc9 into kubernetes-sigs:main Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants